Add Comments and Downvotes to Schema #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-parks
approved these changes
Dec 31, 2024
benjamin-parks
left a comment
benjamin-parks
left a comment
There was a problem hiding this comment.
upvotes, downvotes and comments all populate properly on my end when seeding. lgtm!
coopbri
reviewed
Jan 1, 2025
coopbri
reviewed
Jan 1, 2025
coopbri
reviewed
Jan 1, 2025
Co-authored-by: Brian Cooper <20056195+coopbri@users.noreply.github.com>
Co-authored-by: Brian Cooper <20056195+coopbri@users.noreply.github.com>
This reverts commit d6959b1.
coopbri
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task links: https://linear.app/omnidev/issue/OMNI-141/add-comments-to-database-schema and https://linear.app/omnidev/issue/OMNI-84/add-downvotes-to-database-schema
Updated the database schema to include tables for comments on related posts (feedback) as well as a downvotes table for said post. Updated the seed script and executable schema accordingly.
Test Steps
Note
One issue that I see with the seed script is that you can't deterministically make sure each post has a certain number of upvotes and downvotes due to the composite unique constraints on those tables. Keep this in mind when testing the App in insert PR here as you may need to change user ID env to properly find a feedback item that has upvotes / downvotes.